Repository navigation
fix(patches): preserve previews for zero-padded hunk counts - #1297
Draft
mldangelo-oai wants to merge 119 commits into
Draft
mldangelo-oai wants to merge 119 commits into
mldangelo-oai wants to merge 119 commits into
Conversation
…/codex/patch-snapshot-accounting
…/codex/patch-snapshot-accounting
…/codex/patch-snapshot-accounting
…/codex/patch-snapshot-accounting
…/codex/patch-snapshot-accounting
…/codex/patch-snapshot-accounting
…napshot-accounting # Conflicts: # sdk/typescript/tests-ts/support/cli-patch-context.mts
Local comparison foundation for the patch snapshot follow-up.
…/codex/patch-snapshot-accounting
…-integrity' into HEAD # Conflicts: # sdk/typescript/tests-ts/support/cli-patch-context.mts
…counting' into HEAD
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
mldangelo-oai
changed the title
mldangelo-oai
added
area:patches
mldangelo-oai
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Git accepts hunk counts with thousands of leading zeros, but Python can reject their conversion. Strip only the leading zeros so valid patches keep their preview and statistics.
Depends on #1262.
Changes
Testing
Recorded validation passed seven focused parser and saved-scan tests, Ruff lint/format, SDK build:ci, portable source compatibility, and all nine checker tests. Complete platform runs remain tracked in the PR checks.
Risk and rollout
Depends on #1262. Count values, digest checks, and optional-preview failure behavior are preserved. Full platform checks and the existing incomplete disclosure review remain merge conditions. The PR remains a draft.
Public disclosure review
The accessible branch name, title, body, commits, changed source, review material, and recorded test artifacts were reviewed. Some previously linked automated security-report content has unavailable or restricted visibility; maintainers should complete that linked-content review before merging. No restricted report link or identifier is added here.